From dac471f0a66f8eea61892f70105d1ae15d3a8840 Mon Sep 17 00:00:00 2001
From: sarendsen <coding-mosses0z@icloud.com>
Date: Fri, 24 Jan 2025 08:55:02 +0100
Subject: [PATCH] feat: hide sections when empty by default

---
 app/(auth)/(tabs)/(home)/index.tsx          |  8 +++--
 components/home/ScrollingCollectionList.tsx |  3 +-
 utils/atoms/settings.ts                     | 33 +++++++++++++--------
 3 files changed, 28 insertions(+), 16 deletions(-)

diff --git a/app/(auth)/(tabs)/(home)/index.tsx b/app/(auth)/(tabs)/(home)/index.tsx
index fdbe0ea2..6864c4d2 100644
--- a/app/(auth)/(tabs)/(home)/index.tsx
+++ b/app/(auth)/(tabs)/(home)/index.tsx
@@ -207,7 +207,7 @@ export default function index() {
       const latestMediaViews = collections.map((c) => {
         const includeItemTypes: BaseItemKind[] =
           c.CollectionType === "tvshows" ? ["Series"] : ["Movie"];
-        const title = t("home.recently_added_in", {libraryName: c.Name});
+        const title = t("home.recently_added_in", { libraryName: c.Name });
         const queryKey = [
           "home",
           "recentlyAddedIn" + c.CollectionType,
@@ -352,7 +352,7 @@ export default function index() {
       <View className="flex flex-col items-center justify-center h-full -mt-6 px-8">
         <Text className="text-3xl font-bold mb-2">{t("home.no_internet")}</Text>
         <Text className="text-center opacity-70">
-        {t("home.no_internet_message")}
+          {t("home.no_internet_message")}
         </Text>
         <View className="mt-4">
           <Button
@@ -393,7 +393,9 @@ export default function index() {
     return (
       <View className="flex flex-col items-center justify-center h-full -mt-6">
         <Text className="text-3xl font-bold mb-2">{t("home.oops")}</Text>
-        <Text className="text-center opacity-70">{t("home.error_message")}</Text>
+        <Text className="text-center opacity-70">
+          {t("home.error_message")}
+        </Text>
       </View>
     );
 
diff --git a/components/home/ScrollingCollectionList.tsx b/components/home/ScrollingCollectionList.tsx
index 06f5a057..092059d6 100644
--- a/components/home/ScrollingCollectionList.tsx
+++ b/components/home/ScrollingCollectionList.tsx
@@ -42,7 +42,8 @@ export const ScrollingCollectionList: React.FC<Props> = ({
 
   const { t } = useTranslation();
 
-  if (hideIfEmpty === true && data?.length === 0) return null;
+  // hideIfEmpty is deprecated, we always hide when there is no data
+  if (hideIfEmpty === true || data?.length === 0) return null;
   if (disabled || !title) return null;
 
   return (
diff --git a/utils/atoms/settings.ts b/utils/atoms/settings.ts
index 7483c039..3beff72a 100644
--- a/utils/atoms/settings.ts
+++ b/utils/atoms/settings.ts
@@ -28,16 +28,26 @@ export const ScreenOrientationEnum: Record<
   ScreenOrientation.OrientationLock,
   string
 > = {
-  [ScreenOrientation.OrientationLock.DEFAULT]: "home.settings.other.orientations.DEFAULT",
-  [ScreenOrientation.OrientationLock.ALL]: "home.settings.other.orientations.ALL",
-  [ScreenOrientation.OrientationLock.PORTRAIT]: "home.settings.other.orientations.PORTRAIT",
-  [ScreenOrientation.OrientationLock.PORTRAIT_UP]: "home.settings.other.orientations.PORTRAIT_UP",
-  [ScreenOrientation.OrientationLock.PORTRAIT_DOWN]: "home.settings.other.orientations.PORTRAIT_DOWN",
-  [ScreenOrientation.OrientationLock.LANDSCAPE]: "home.settings.other.orientations.LANDSCAPE",
-  [ScreenOrientation.OrientationLock.LANDSCAPE_LEFT]: "home.settings.other.orientations.LANDSCAPE_LEFT",
-  [ScreenOrientation.OrientationLock.LANDSCAPE_RIGHT]: "home.settings.other.orientations.LANDSCAPE_RIGHT",
-  [ScreenOrientation.OrientationLock.OTHER]: "home.settings.other.orientations.OTHER",
-  [ScreenOrientation.OrientationLock.UNKNOWN]: "home.settings.other.orientations.UNKNOWN",
+  [ScreenOrientation.OrientationLock.DEFAULT]:
+    "home.settings.other.orientations.DEFAULT",
+  [ScreenOrientation.OrientationLock.ALL]:
+    "home.settings.other.orientations.ALL",
+  [ScreenOrientation.OrientationLock.PORTRAIT]:
+    "home.settings.other.orientations.PORTRAIT",
+  [ScreenOrientation.OrientationLock.PORTRAIT_UP]:
+    "home.settings.other.orientations.PORTRAIT_UP",
+  [ScreenOrientation.OrientationLock.PORTRAIT_DOWN]:
+    "home.settings.other.orientations.PORTRAIT_DOWN",
+  [ScreenOrientation.OrientationLock.LANDSCAPE]:
+    "home.settings.other.orientations.LANDSCAPE",
+  [ScreenOrientation.OrientationLock.LANDSCAPE_LEFT]:
+    "home.settings.other.orientations.LANDSCAPE_LEFT",
+  [ScreenOrientation.OrientationLock.LANDSCAPE_RIGHT]:
+    "home.settings.other.orientations.LANDSCAPE_RIGHT",
+  [ScreenOrientation.OrientationLock.OTHER]:
+    "home.settings.other.orientations.OTHER",
+  [ScreenOrientation.OrientationLock.UNKNOWN]:
+    "home.settings.other.orientations.UNKNOWN",
 };
 
 export const DownloadOptions: DownloadOption[] = [
@@ -241,12 +251,11 @@ export const useSettings = () => {
     if (!api) return;
     const settings = await api.getStreamyfinPluginConfig().then(
       ({ data }) => {
-        writeInfoLog(`Got remote settings`);
+        writeInfoLog(`Got remote settings: ${data?.settings}`);
         return data?.settings;
       },
       (err) => undefined
     );
-
     setPluginSettings(settings);
     return settings;
   }, [api]);