wip

modules/vlc-player/ios/VlcPlayerModule.swift

@@ -77,10 +77,10 @@ public class VlcPlayerModule: Module {
                 return view.getVideoCropGeometry()
             }
 
-            AsyncFunction("setSubtitleURL") { (view: VlcPlayerView, url: String) in
-                view.setSubtitleURL(url)
+            AsyncFunction("setSubtitleURL") {
+                (view: VlcPlayerView, url: String, name: String) in
+                view.setSubtitleURL(url, name: name)
             }
-
         }
     }
 }

modules/vlc-player/ios/VlcPlayerView.swift

@@ -11,6 +11,7 @@ class VlcPlayerView: ExpoView {
     private var lastReportedState: VLCMediaPlayerState?
     private var lastReportedIsPlaying: Bool?
     private var isMediaReady: Bool = false
+    private var customSubtitles: [(internalName: String, originalName: String)] = []
 
     // MARK: - Initialization
 
@@ -198,14 +199,6 @@ class VlcPlayerView: ExpoView {
         }
     }
 
-    @objc func loadExternalSubtitle(_ subtitlePath: String) {
-        DispatchQueue.main.async { [weak self] in
-            guard let self = self else { return }
-            self.mediaPlayer?.addPlaybackSlave(
-                URL(fileURLWithPath: subtitlePath), type: .subtitle, enforce: true)
-        }
-    }
-
     @objc func setMuted(_ muted: Bool) {
         DispatchQueue.main.async {
             self.mediaPlayer?.audio?.isMuted = muted
@@ -296,7 +289,7 @@ class VlcPlayerView: ExpoView {
         }
     }
 
-    @objc func setSubtitleURL(_ subtitleURL: String) {
+    @objc func setSubtitleURL(_ subtitleURL: String, name: String) {
         DispatchQueue.main.async { [weak self] in
             guard let self = self, let url = URL(string: subtitleURL) else {
                 print("Error: Invalid subtitle URL")
@@ -305,7 +298,9 @@ class VlcPlayerView: ExpoView {
 
             let result = self.mediaPlayer?.addPlaybackSlave(url, type: .subtitle, enforce: true)
             if let result = result {
-                print("Subtitle added with result: \(result)")
+                let internalName = "Track \(self.customSubtitles.count + 1)"
+                print("Subtitle added with result: \(result) \(internalName)")
+                self.customSubtitles.append((internalName: internalName, originalName: name))
             } else {
                 print("Failed to add subtitle")
             }
@@ -318,10 +313,7 @@ class VlcPlayerView: ExpoView {
         }
 
         let count = mediaPlayer.numberOfSubtitlesTracks
-
-        print(
-            "Debug: Number of subtitle tracks: \(count)"
-        )
+        print("Debug: Number of subtitle tracks: \(count)")
 
         guard count > 0 else {
             return nil
@@ -333,10 +325,15 @@ class VlcPlayerView: ExpoView {
             let indexes = mediaPlayer.videoSubTitlesIndexes as? [NSNumber]
         {
             for (index, name) in zip(indexes, names) {
-                tracks.append(["name": name, "index": index.intValue])
+                if let customSubtitle = customSubtitles.first(where: { $0.internalName == name }) {
+                    tracks.append(["name": customSubtitle.originalName, "index": index.intValue])
+                } else {
+                    tracks.append(["name": name, "index": index.intValue])
+                }
             }
         }
 
+        print("Debug: Subtitle tracks: \(tracks)")
         return tracks
     }
 

modules/vlc-player/src/VlcPlayer.types.ts

@@ -82,5 +82,5 @@ export interface VlcPlayerViewRef {
   getChapters: () => Promise<ChapterInfo[] | null>;
   setVideoCropGeometry: (geometry: string | null) => Promise<void>;
   getVideoCropGeometry: () => Promise<string | null>;
-  setSubtitleURL: (url: string) => Promise<void>;
+  setSubtitleURL: (url: string, name: string) => Promise<void>;
 }

modules/vlc-player/src/VlcPlayerView.tsx

@@ -78,8 +78,8 @@ const VlcPlayerView = React.forwardRef<VlcPlayerViewRef, VlcPlayerViewProps>(
         const geometry = await nativeRef.current?.getVideoCropGeometry();
         return geometry ?? null;
       },
-      setSubtitleURL: async (url: string) => {
-        await nativeRef.current?.setSubtitleURL(url);
+      setSubtitleURL: async (url: string, name: string) => {
+        await nativeRef.current?.setSubtitleURL(url, name);
       },
     }));